Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly present help when posargs have no help #5178

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

sergiusens
Copy link
Collaborator

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lengau
Copy link
Contributor

lengau commented Dec 12, 2024

@mr-cal huh, that's a fascinating side-effect, but I think you're right.

@sergiusens sergiusens requested review from mr-cal and lengau December 13, 2024 14:48
@sergiusens sergiusens changed the title fix: properly persent help when posargs have no help fix: properly present help when posargs have no help Dec 13, 2024
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@mr-cal mr-cal merged commit f97d032 into hotfix/8.5 Dec 16, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants