Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: migrate env-injector and gnome extension pages #5212

Merged
merged 12 commits into from
Jan 30, 2025
Merged

docs: migrate env-injector and gnome extension pages #5212

merged 12 commits into from
Jan 30, 2025

Conversation

medubelko
Copy link
Contributor

  • Add some indexes.

  • Add new how-tos about extensions.

  • Have you followed the guidelines for contributing?

  • Have you signed the CLA?

  • Have you successfully run tox run -m lint?

  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (654871d) to head (25b4f82).
Report is 682 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (25b4f82). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (654871d) HEAD (25b4f82)
2 1
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5212      +/-   ##
==========================================
- Coverage   94.88%   89.69%   -5.20%     
==========================================
  Files         658      343     -315     
  Lines       55189    22687   -32502     
==========================================
- Hits        52364    20348   -32016     
+ Misses       2825     2339     -486

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@medubelko medubelko force-pushed the craft-3579-env-injector-gnome-extensions branch from 777b0d7 to 14418f0 Compare January 28, 2025 02:00
@medubelko medubelko marked this pull request as ready for review January 28, 2025 02:01
@medubelko medubelko requested a review from mr-cal January 28, 2025 02:01
medubelko
medubelko commented Jan 28, 2025
View reviewed changes
Copy link
Contributor Author

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mr-cal @lengau Incorporated your suggestions, plus some refinements.

docs/reference/code/extensions/gnome-extension-gnome-system-monitor-expanded-diff.yaml Outdated Show resolved Hide resolved
docs/reference/extensions/gnome-extension.rst Outdated Show resolved Hide resolved
docs/reference/extensions/gnome-extension.rst Show resolved Hide resolved
docs/reference/extensions/gnome-extension.rst Outdated Show resolved Hide resolved
docs/reference/extensions/gnome-extension.rst Outdated Show resolved Hide resolved
@medubelko medubelko requested a review from lengau January 28, 2025 02:08
@medubelko
docs: fix lint errors
92d0b87 
Give example diff a `.diff` extension to work around YAML linter.
mr-cal
mr-cal approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written, nice work!

docs/howto/use-extensions/list-extensions.rst Show resolved Hide resolved
docs/howto/use-extensions/use-the-env-injector-extension.rst Outdated Show resolved Hide resolved
docs/howto/use-extensions/use-the-env-injector-extension.rst Outdated Show resolved Hide resolved
docs/reference/extensions/env-injector-extension.rst Outdated Show resolved Hide resolved
docs/reference/extensions/gnome-extension.rst Outdated Show resolved Hide resolved
docs/reference/extensions/gnome-extension.rst Outdated Show resolved Hide resolved
@medubelko medubelko requested a review from jahn-junior January 28, 2025 19:02
jahn-junior
jahn-junior approved these changes Jan 28, 2025
View reviewed changes
Copy link

@jahn-junior jahn-junior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of typo fixes. Looks good!

docs/howto/use-extensions/use-the-env-injector-extension.rst Outdated Show resolved Hide resolved
docs/howto/use-extensions/use-the-gnome-extension.rst Outdated Show resolved Hide resolved
docs/reference/extensions/gnome-extension.rst Outdated Show resolved Hide resolved
docs/reference/extensions/gnome-extension.rst Outdated Show resolved Hide resolved
docs/reference/extensions/index.rst Outdated Show resolved Hide resolved
@medubelko medubelko requested a review from lengau January 30, 2025 00:29
lengau
lengau approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work and patience on this! I've left one loose suggestion and left one comment thread open with details of why I think your word choice is fine but a possible replacement if you're uncomfortable with it.

@medubelko
Copy link
Contributor Author

@mr-cal This should be good to merge after the tests finish.

@medubelko
docs: add missing extension how-to
b993974 
In all the shuffling between the branches, this somehow got lost.
@mr-cal
Copy link
Collaborator

mr-cal commented Jan 30, 2025

@mr-cal This should be good to merge after the tests finish.

I'll land it today

@medubelko medubelko mentioned this pull request Jan 30, 2025
Merged
4 tasks
@medubelko
Copy link
Contributor Author

Grr, the extra commits are coming because of code sharing shenanigans between branches.

@mr-cal
Copy link
Collaborator

mr-cal commented Jan 30, 2025

All relevant tests have passed, merging.

@mr-cal mr-cal merged commit a30134d into canonical:main Jan 30, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@jahn-junior jahn-junior jahn-junior approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@medubelko @mr-cal @lengau @jahn-junior