Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-aux/snap, .github/workflows: bump go snap version for building and testing snapd snap #14752

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ernestl
Copy link
Collaborator

@ernestl ernestl commented Nov 21, 2024

Bump the version of go snap used for building and testing snapd snap

Overview:

  • Static checks and unit tests run with both (1) the go channel that snapd snap is build with and (2) and latest/stable
  • Avoid manual workflow changes for channel updates, by looking up snapd build go channel from snapcraft.yaml
  • Also supports looking up Go snap channel for snapd FIPS
  • Avoid job duplication if versions are the same e.g. "1.23/stable" and "latest/stable"
  • Avoid manual branch "required" maintenance by using statically named gatekeepers for unit test and static checks that always run and evaluate all results even if dependencies are skipped

Take note:

  • Temp intentional unit test failure do demonstrate more dynamic "required" solution
  • Open question on if/how exactly we want to test for FIPS
  • There are a lot of cancelled required tests, this is expected given the change, and will be solved by simplifying branch rules after landing the PR.

Addtional Info:

Jira: https://warthogs.atlassian.net/browse/SNAPDENG-33212

@ernestl ernestl added the Skip spread Indicate that spread job should not run label Nov 21, 2024
@ernestl ernestl force-pushed the SNAPDENG-33212_Bump_Go_Version branch 3 times, most recently from f110597 to 06c468e Compare November 21, 2024 10:37
@ernestl ernestl changed the title build-aux/snap, .github/workflows: bump go snap version used for building and testing snapd snap build-aux/snap, .github/workflows: bump go snap version for building and testing snapd snap Nov 21, 2024
@ernestl ernestl force-pushed the SNAPDENG-33212_Bump_Go_Version branch 4 times, most recently from ace652b to 5560ca0 Compare November 21, 2024 12:16
@ernestl ernestl closed this Nov 21, 2024
@ernestl ernestl reopened this Nov 21, 2024
@ernestl ernestl force-pushed the SNAPDENG-33212_Bump_Go_Version branch 4 times, most recently from e23ab13 to 8c443f0 Compare November 21, 2024 13:27
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.20%. Comparing base (96ea7b0) to head (c969f94).
Report is 102 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14752      +/-   ##
==========================================
- Coverage   78.95%   78.20%   -0.75%     
==========================================
  Files        1084     1148      +64     
  Lines      146638   151144    +4506     
==========================================
+ Hits       115773   118200    +2427     
- Misses      23667    25626    +1959     
- Partials     7198     7318     +120     
Flag Coverage Δ
unittests 78.20% <ø> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ernestl ernestl force-pushed the SNAPDENG-33212_Bump_Go_Version branch 2 times, most recently from c508da1 to b0593d6 Compare November 23, 2024 00:31
…nap for testing

.github/workflows: changed versions to channels and other corrections
@ernestl ernestl force-pushed the SNAPDENG-33212_Bump_Go_Version branch from b0593d6 to 9dd8392 Compare November 23, 2024 00:53
@ernestl ernestl added this to the 2.68 milestone Nov 25, 2024
@ernestl ernestl marked this pull request as ready for review November 25, 2024 08:50
@bboozzoo bboozzoo self-requested a review November 25, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip spread Indicate that spread job should not run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant