Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix reexec tests when SNAP_REEXEC=0 #14753

Merged

Conversation

sergiocazzolato
Copy link
Collaborator

Those tests are failing when we ran it for SRU validation, I used tests.exec to make sure prepare, execute and restore phases are properly skipped.

Those tests are failing when we ran it for SRU validation, I used
tests.exec to make sure prepare, execute and restore phases are properly
skipped.
@sergiocazzolato sergiocazzolato added the Simple 😃 A small PR which can be reviewed quickly label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.02%. Comparing base (96ea7b0) to head (3d9d9e2).
Report is 112 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14753      +/-   ##
==========================================
+ Coverage   78.95%   79.02%   +0.07%     
==========================================
  Files        1084     1087       +3     
  Lines      146638   147756    +1118     
==========================================
+ Hits       115773   116771     +998     
- Misses      23667    23753      +86     
- Partials     7198     7232      +34     
Flag Coverage Δ
unittests 79.02% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sergiocazzolato sergiocazzolato merged commit b81b1f7 into canonical:master Nov 27, 2024
56 checks passed
@sergiocazzolato sergiocazzolato deleted the tests-update-reexec-tests branch November 27, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants