interfaces: support Tegra display drivers #7173
Conversation
interfaces/builtin/opengl.go
Outdated
| /sys/devices/pci[0-9a-f]*/**/revision r, | ||
| /sys/devices/pci[0-9a-f]*/**/{,subsystem_}device r, | ||
| /sys/devices/pci[0-9a-f]*/**/{,subsystem_}vendor r, | ||
| /sys/devices/**pci[0-9a-f]*/**/config r, |
There was a problem hiding this comment.
What is the ** for? what was the actual path you saw here?
There was a problem hiding this comment.
It is in the commit message:
/sys/devices/1003000.pcie-controller/pci0000:00/0000:00:02.0/*
interfaces/builtin/opengl.go
Outdated
| @@ -121,6 +125,7 @@ var openglConnectedPlugUDev = []string{ | |||
| `KERNEL=="renderD[0-9]*"`, | |||
| `KERNEL=="nvhost-*"`, | |||
| `KERNEL=="nvmap"`, | |||
| `KERNEL=="tegra_dc_*"`, | |||
There was a problem hiding this comment.
Did you see any additional devices in /dev that snap-confine's Nvidia code needs to support?
There was a problem hiding this comment.
No, fortunately these devices do show in /sys and have proper udev properties.
alfonsosanchezbeato
changed the title
zyga
changed the title
interfaces/builtin/opengl.go
Outdated
| @@ -83,6 +83,9 @@ unix (bind,listen) type=seqpacket addr="@cuda-uvmfd-[0-9a-f]*", | |||
| /dev/nvhost-* rw, | |||
| /dev/nvmap rw, | |||
|
|
|||
| # Tegra display driver | |||
| /dev/tegra_dc_* rw, | |||
There was a problem hiding this comment.
tegra_dc_ctrl, tegra_dc_0 and tegra_dc_1 (control device plus additional devices per display you can connect).
There was a problem hiding this comment.
I have created slightly more fine-grained rules.
interfaces/builtin/opengl.go
Outdated
| /sys/devices/**pci[0-9a-f]*/**/revision r, | ||
| /sys/devices/**pci[0-9a-f]*/**/{,subsystem_}class r, | ||
| /sys/devices/**pci[0-9a-f]*/**/{,subsystem_}device r, | ||
| /sys/devices/**pci[0-9a-f]*/**/{,subsystem_}vendor r, |
There was a problem hiding this comment.
Can you adjust these to be somewhat finer with:
/sys/devices/{,*pcie-controller/}pci[0-9a-f]*/**/config r,
/sys/devices/{,*pcie-controller/}pci[0-9a-f]*/**/revision r,
/sys/devices/{,*pcie-controller/}pci[0-9a-f]*/**/{,subsystem_}class r,
/sys/devices/{,*pcie-controller/}pci[0-9a-f]*/**/{,subsystem_}device r,
/sys/devices/{,*pcie-controller/}pci[0-9a-f]*/**/{,subsystem_}vendor r,
There was a problem hiding this comment.
Sure, will do
Tegra drivers try to read this path: /sys/devices/1003000.pcie-controller/pci0000:00/0000:00:02.0/* Consider this case by allowing parent directories before the pci0000:00 folder.
Allow access to devices created by the Tegra display driver.
Make tests pass now that Tegra display driver has been added to the opengl interface.
alfonsosanchezbeato
force-pushed
the
x11-tegra
branch
from
5f2a938
to
706cb0b
Compare
|
@jdstrand ping |
|
Comment added now |
Support Tegra display drivers in x11/opengl interfaces