Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 2FA for staging and production #55

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

shanepelletier
Copy link
Contributor

After the new changes which use the craft-store Python package for logging in to the Snap Store, surl would assume that only production accounts were protected by 2FA. This change allows surl to use 2FA for both production and staging accounts.

Copy link

@bowenfan96 bowenfan96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@lofidevops
Copy link

Looks good. Could we be more explicit than Exception?

@tartley
Copy link

tartley commented Apr 15, 2024

Hi, good people! I guess I can unstar this repo :-)

Hope life is good. It must be 9 months since I left. (!) I'm enjoying my new job, just had a big trip to see my folks in North England, plus some real vacation in the Canary Islands, and now we have a Brazilian exchange football coach living in the house. And I'm working on a vector-graphic "Missile Command" with the kiddo (https://tartley.itch.io/missile-commander for Linux, Windows binaries, and the source runs on Macs from in Godot)

So anyhow, life is good. Hope you lovelies are doing well, too!

  • Jonathan

@shanepelletier
Copy link
Contributor Author

Looks good. Could we be more explicit than Exception?

I actually wasn't sure this was possible but it turns out it was rather easy, so sure!

Hi, good people!

Jonathan, hey! Long time no chat! Glad to hear things are going well with you :).

@shanepelletier shanepelletier merged commit 8db1d20 into canonical:master Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants