Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleting VM hosts of dynamic machines do not try release #138

Merged

Conversation

skatsaounis
Copy link
Collaborator

Addresses #137 and also improves the update by removing the unnecessary VM host get call

Copy link
Member

@troyanov troyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skatsaounis not sure I understand the change. Can you please clarify a bit? Thanks!

maas/resource_maas_vm_host.go Show resolved Hide resolved
maas/resource_maas_vm_host.go Show resolved Hide resolved
maas/resource_maas_vm_host.go Show resolved Hide resolved
@skatsaounis skatsaounis merged commit 006b94a into canonical:master Jan 16, 2024
5 checks passed
@skatsaounis skatsaounis deleted the fix-delete-vm-host-dynamic branch January 16, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants