Update to base22 #46
Merged
Update to base22 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will give us e.g. 0+git.97b967f which is sufficient, no need to engineer a more complex one. Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
When based on core18 it started to hit ssl issues when talking to launchpad, like: ssl.SSLError: [SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:852) This can be reproduced in `snap run --shell ustriage` but not in a bionic lxd system. While it could be debugged and fixed inside core18, bumping this up is good overall. Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Without this core22 would hit: ModuleNotFoundError: No module named 'yaml' Inspired from more mature core22 python snaps like MAAS which had this set as well [1]. There and in many others it was added with core20 and carried since. [1]: https://github.com/maas/maas/blob/master/snap/snapcraft.yaml#L26 Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among just making it more modern this fixes authentication issues of core18 openssl/python combination with launchpad.
Issue was like: