Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: add info about the build and release steps #48

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

cpaelzer
Copy link
Contributor

We just had the need to rebuild for a security issue, and while I faintly remembered how to do that it wasn't written down.
Therefore I added the basic steps, linking to the required pages and some references of the snap docs. This shall help anyone else needing to do that to feel more comfortable in doing so.

Food for thought, some of these pages are restricted to authorized people, currently robie, sergio, bryce, paride and myself. I'm not sure how to mention that in the doc - or if I even should? WDTY?

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Copy link
Member

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not going to merge but it lgtm on a quick glace.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions, otherwise LGTM :)

cpaelzer and others added 4 commits July 25, 2024 11:00
Co-authored-by: Sally <sally.makin@canonical.com>
Co-authored-by: Sally <sally.makin@canonical.com>
Co-authored-by: Sally <sally.makin@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
@cpaelzer
Copy link
Contributor Author

I also fixed the remaining misunderstandable sentence and quickly checked with Robie to make sense now.
Merging ...

@cpaelzer cpaelzer merged commit ce7339f into canonical:master Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants