Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump vault to 1.18.3 #57

Merged
merged 2 commits into from
Jan 20, 2025
Merged

chore: bump vault to 1.18.3 #57

merged 2 commits into from
Jan 20, 2025

Conversation

gruyaume
Copy link
Collaborator

Description

Here we bump the Vault version to the latest from the upstream.

Prior to merging this PR we also need to create a git branch for 1.17.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Signed-off-by: Guillaume Belanger <guillaume.belanger27@gmail.com>
@gruyaume gruyaume requested a review from a team as a code owner January 16, 2025 16:22
@gruyaume gruyaume enabled auto-merge (squash) January 16, 2025 18:05
@gruyaume gruyaume closed this Jan 17, 2025
auto-merge was automatically disabled January 17, 2025 14:39

Pull request was closed

@gruyaume gruyaume reopened this Jan 17, 2025
Signed-off-by: Guillaume Belanger <guillaume.belanger27@gmail.com>
@DanielArndt DanielArndt reopened this Jan 20, 2025
@DanielArndt
Copy link
Member

@gruyaume It seems like this wasn't building because GitHub apparently disables workflows if there has been nothing for 60 days. I just had to re-enable it here: https://github.com/canonical/vault-rock/actions/workflows/main.yaml

I noticed the same thing with my lego-rock change, although it appears that's not the only thing wrong with mine: canonical/lego-rock#44

@gruyaume
Copy link
Collaborator Author

@gruyaume It seems like this wasn't building because GitHub apparently disables workflows if there has been nothing for 60 days. I just had to re-enable it here: https://github.com/canonical/vault-rock/actions/workflows/main.yaml

I noticed the same thing with my lego-rock change, although it appears that's not the only thing wrong with mine: canonical/lego-rock#44

Good catch! I was struggling to find the cause

@gruyaume gruyaume merged commit 791914d into main Jan 20, 2025
8 checks passed
@gruyaume gruyaume deleted the dev-1.18 branch January 20, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants