-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cantaloup 5.0.6 #641
Cantaloup 5.0.6 #641
Conversation
Created a basic CREDITS.md but should credit the other people who have contributed. |
S3 tests: "For the S3 tests, I use minio or s3proxy (https://github.com/gaul/s3proxy) running locally. The S3 tests work in CI using minio. My S3 keys in test.properties look like: s3.service = minio Looks like the s3 tests are part of the CI anyway so no need to test this seperatly. |
Running: mvn verify -DskipTests=true
|
Updating the dependency-check-maven plugin which runs the verify code to latest (5.2.4 -> 9.0.9) results in the following issues:
Resolutions:
Down to:
|
Running Spotbugs some small things but nothing I think that needs fixing. |
It looks like s3 version 2.21.4 is the first one to use netty-transport 4.1.100.Final which is the one with the fix. |
OK on to the release procedure. |
Todo: