Test with OpenJDK 17 & 21 (LTS) #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
openjdk17lts
branch
3 times, most recently
from
8128852
to
c47ac1a
Compare
|
@jcoyne @glenrobson are we dropping 11? RE #654 ? Or it is a keeper? |
|
@DiegoPino I was planning on doing that separately to avoid tying the two changes together in case removal of 11 becomes contentious. |
DiegoPino
reviewed
Aug 15, 2024
|
|
||
| # Install TurboJpegProcessor dependencies | ||
| RUN mkdir -p /opt/libjpeg-turbo/lib | ||
| COPY docker/Linux-JDK11/image_files/libjpeg-turbo/lib64 /opt/libjpeg-turbo/lib |
There was a problem hiding this comment.
We might want to move the built jpeg-turbo library into a shared space in case we deprecate JDK11. Just a note
DiegoPino
reviewed
Aug 15, 2024
| RUN mvn --quiet dependency:resolve | ||
|
|
||
| # Copy the code | ||
| COPY --chown=cantaloupe docker/Linux-JDK11/image_files/test.properties test.properties |
There was a problem hiding this comment.
same with the test.properties. Should be in a shared space instead of inside a specific JDK folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #654