Merge pull request #966 from ex1st/master

Incorrect handling of arguments in "auto" in case of empty callback
caolan · Dec 3, 2015 · f9f6204 · f9f6204
2 parents 0c60ded + c744ab6
commit f9f6204
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/async.js b/lib/async.js
@@ -510,7 +510,7 @@
     };
 
     async.auto = function (tasks, concurrency, callback) {
-        if (!callback) {
+        if (typeof arguments[1] === 'function') {
             // concurrency is optional, shift the args.
             callback = concurrency;
             concurrency = null;

diff --git a/test/test-async.js b/test/test-async.js
@@ -426,7 +426,6 @@ exports['auto results'] = function(test){
     });
 };
 
-
 exports['auto empty object'] = function(test){
     async.auto({}, function(err){
         test.ok(err === null, err + " passed instead of 'null'");
@@ -461,6 +460,13 @@ exports['auto no callback'] = function(test){
     });
 };
 
+exports['auto concurrency no callback'] = function(test){
+    async.auto({
+        task1: function(callback){callback();},
+        task2: ['task1', function(callback){callback(); test.done();}]
+    }, 1);
+};
+
 exports['auto error should pass partial results'] = function(test) {
     async.auto({
         task1: function(callback){