Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pause in queue with concurrency doesn't pause #945

Closed
adam-26 opened this issue Oct 28, 2015 · 0 comments
Closed

Pause in queue with concurrency doesn't pause #945

adam-26 opened this issue Oct 28, 2015 · 0 comments
Labels
bug

Comments

@adam-26
Copy link
Contributor

adam-26 commented Oct 28, 2015

Hi,

The queue will continue to process tasks when these conditions are met:

  • using a queue with a concurrency > 1
  • the task pauses the queue
  • the task is long running and the callback is not called before adding more items to the queue

I will submit a pull request to resolve this.

Adam.
adam-26 added a commit to adam-26/async that referenced this issue Oct 28, 2015
@adam-26
Bug fix caolan#945: remove commented code
19f0d0f
@adam-26 adam-26 mentioned this issue Oct 28, 2015
Merged
@megawac megawac added the bug label Oct 28, 2015
megawac added a commit that referenced this issue Oct 29, 2015
@megawac
Merge pull request #946 from adam-26/master
4643f6f 
Bug fix #945 - Pause in queue with concurrency doesn't pause
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adam-26 @megawac