Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #945 - Pause in queue with concurrency doesn't pause #946

Merged
merged 3 commits into from
Oct 29, 2015

Conversation

adam-26
Copy link
Contributor

@adam-26 adam-26 commented Oct 28, 2015

Refer to issue #945

@megawac megawac added the bug label Oct 28, 2015
@@ -931,6 +931,10 @@
process: function () {
if (!q.paused && workers < q.concurrency && q.tasks.length) {
while(workers < q.concurrency && q.tasks.length){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to

- if (!q.paused && workers < q.concurrency && q.tasks.length) { 
- while(workers < q.concurrency && q.tasks.length){ 
+ while (!q.paused && workers < q.concurrency && q.tasks.length) {

@adam-26
Copy link
Contributor Author

adam-26 commented Oct 29, 2015

Done

megawac added a commit that referenced this pull request Oct 29, 2015
Bug fix #945 - Pause in queue with concurrency doesn't pause
@megawac megawac merged commit 4643f6f into caolan:master Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants