ES6-ify codebase #1553
Merged
ES6-ify codebase #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I'm surprised you didn't have to touch the eslintrc. How is the performance before and after making these changes? I'm most curious about the performance of |
|
There's so many big changes coming in, this is awesome! LGTM. |
|
In Node 8 and 10, the benchmarks were about the same. No method was significantly faster or slower than another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of arrows and rest-params! I also got rid of some internal functions that were either no longer needed (
slice), or better inlined (forOwn,notId, etc.)Closes #1541