Completing forEachOf #705
Merged
Completing forEachOf #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Would be great to finally see this make it in there! |
| @@ -68,6 +68,14 @@ | |||
| return memo; | |||
| }; | |||
|
|
|||
| var _forEachOf = function (object, iterator) { | |||
| for (key in object) { | |||
There was a problem hiding this comment.
May i ask why you don't use Object.keys() ?
There was a problem hiding this comment.
No reason, I kept the original implementation. I was focused more on merge conflicts. _keys would be faster here...
|
Oh oops, I misread. Totally fine then. :) |
|
+1 |
|
+1 |
|
+1 (when will github add issue voting?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly @dominicbarnes 's work from #168. The last missing piece was documentation, which I added. I also made sure it merges with what is currently on master, and simplified the logic in one place.