Replace slice with restParam

[megawac]

This has been known to greatly simplify code (heavily used in underscore and lodash) and be a great optimization (slicing arguments is sloooooooooooow).

If interested, refer to these threads for documentation, benchmarks, arguments, naming, etc:-)

• Add _.restParam jashkenas/underscore#2140
• Spread Last Parameter lodash/lodash#1122
• https://lodash.com/docs#restParam

[megawac]

Line 156-161 is currently unused. Thoughts? I was thinking about just commenting it out as it handles cases not handled by the switch statement

[aearly]

Interesting -- simplifies the code a bit. Is this actually faster, though? What do the benchmarks in perf/ say?

[megawac]

The bench results are essentially the same in all benchmarks +- a couple
milliseconds which makes sense because this is a synch part of a async
test.

On Wed, Jul 1, 2015 at 1:10 PM, Alexander Early notifications@github.com
wrote:

Interesting -- simplifies the code a bit. Is this actually faster, though?
What do the benchmarks in perf say?

—
Reply to this email directly or view it on GitHub
#818 (comment).

[aearly]

Ok, that's fine then. When we switched from Array.prototype.slice to _baseSlice, there was a measurable performance increase! This gives us the same performance with cleaner code, so 👍