This repository has been archived by the owner on Feb 3, 2020. It is now read-only.
Session Tuning #14
Open
Session Tuning #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…main' and make the cookie 'secure' as well as 'max-age' will be sent if useMaxAge is true. Just to be complete, I made it so that you could also selectively turn on/off setting 'expires' and 'HttpOnly' with useExpires and useHttpOnly options, but the defaults shouldn't change any existing uses of cookie-sessions, except that useMaxAge is true by default.
…kes it work with existing unit tests and probably a little more semantically correct.
…milliseconds, not in seconds.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched branches. Here is the original message:
I’ve been using cookie-sessions for a while and thought I’d push back the additions I made. I tried to make it into nice clean commits, but had to make a few corrections along the way. The key changes are that you can now set the 'domain' and make the cookie 'secure' as well as that 'max-age' will be sent if useMaxAge is true (default). Just to be complete, I also made it so that you can also selectively turn off setting 'expires' and 'HttpOnly' with useExpires:false and useHttpOnly: false, but the defaults are that they’re true so it shouldn’t change any existing uses of cookie-sessions.