Fix android http upload bugs (#185)

* Fix Http.uploadFile not allowing a file:// source * Fix Http.uploadFile erroring if method not supplied on android Co-authored-by: Lee Houghton <lee.houghton@connectchildcare.com>
capacitor-community · Nov 9, 2021 · 5ca386c · 5ca386c
1 parent 104f7d2
commit 5ca386c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/android/src/main/java/com/getcapacitor/plugin/http/FilesystemUtils.java b/android/src/main/java/com/getcapacitor/plugin/http/FilesystemUtils.java
@@ -16,7 +16,7 @@ public class FilesystemUtils {
     public static final String DIRECTORY_EXTERNAL_STORAGE = "EXTERNAL_STORAGE";
 
     public static File getFileObject(Context c, String path, String directory) {
-        if (directory == null) {
+        if (directory == null || path.startsWith("file://")) {
             Uri u = Uri.parse(path);
             if (u.getScheme() == null || u.getScheme().equals("file")) {
                 return new File(u.getPath());

diff --git a/android/src/main/java/com/getcapacitor/plugin/http/HttpRequestHandler.java b/android/src/main/java/com/getcapacitor/plugin/http/HttpRequestHandler.java
@@ -471,7 +471,7 @@ public static JSObject downloadFile(PluginCall call, Context context, ProgressEm
      */
     public static JSObject uploadFile(PluginCall call, Context context) throws IOException, URISyntaxException, JSONException {
         String urlString = call.getString("url");
-        String method = call.getString("method").toUpperCase();
+        String method = call.getString("method", "POST").toUpperCase();
         String filePath = call.getString("filePath");
         String fileDirectory = call.getString("fileDirectory", FilesystemUtils.DIRECTORY_DOCUMENTS);
         String name = call.getString("name", "file");