Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

Fix android http upload bugs #185

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Fix android http upload bugs #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77bb3b8
Fix Http.uploadFile not allowing a file:// source
asztal Oct 25, 2021
e1e9fcd
Fix Http.uploadFile erroring if method not supplied on android
asztal Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/src/main/java/com/getcapacitor/plugin/http/FilesystemUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class FilesystemUtils {
public static final String DIRECTORY_EXTERNAL_STORAGE = "EXTERNAL_STORAGE";

public static File getFileObject(Context c, String path, String directory) {
if (directory == null) {
if (directory == null || path.startsWith("file://")) {
Uri u = Uri.parse(path);
if (u.getScheme() == null || u.getScheme().equals("file")) {
return new File(u.getPath());
Expand Down
2 changes: 1 addition & 1 deletion android/src/main/java/com/getcapacitor/plugin/http/HttpRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ public static JSObject downloadFile(PluginCall call, Context context, ProgressEm
*/
public static JSObject uploadFile(PluginCall call, Context context) throws IOException, URISyntaxException, JSONException {
String urlString = call.getString("url");
String method = call.getString("method").toUpperCase();
String method = call.getString("method", "POST").toUpperCase();
String filePath = call.getString("filePath");
String fileDirectory = call.getString("fileDirectory", FilesystemUtils.DIRECTORY_DOCUMENTS);
String name = call.getString("name", "file");
Expand Down