feat: Add isPlaying method #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazuka5801
requested changes
Feb 23, 2022
| @@ -175,6 +175,17 @@ public class NativeAudio: CAPPlugin { | |||
| audioAsset.setVolume(volume: volume as NSNumber) | |||
| call.success() | |||
| } | |||
|
|
|||
| @objc func isPlaying(_ call: CAPPluginCall) { | |||
There was a problem hiding this comment.
Also add definition in Plugin.m file for new method
There was a problem hiding this comment.
I did as you asked. Thanks for your comment.
|
any plan to release isPlaying ? |
indraraj26
suggested changes
Mar 18, 2022
ios/Plugin/AudioAsset.swift
Outdated
|
|
||
| func isPlaying() -> Bool { | ||
| if channels.count != 1 { | ||
| return 0 |
There was a problem hiding this comment.
here it should be return false else it will through the error as it expect return type should be of Boolean
There was a problem hiding this comment.
Thanks, appreciate it
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.