[Identity] Update readme and the native versions with latest minor #306
Conversation
ccen-stripe
changed the title
| @@ -13,6 +13,6 @@ Pod::Spec.new do |s| | |||
| s.source_files = 'ios/Plugin/**/*.{swift,h,m,c,cc,mm,cpp}' | |||
| s.ios.deployment_target = '13.0' | |||
| s.dependency 'Capacitor' | |||
| s.dependency 'StripeIdentity', '23.4.0' | |||
| s.dependency 'StripeIdentity', '~> 23.4.0' | |||
There was a problem hiding this comment.
Here is Identity's React Native iOS version: https://github.com/stripe/stripe-react-native/blob/d565a0b1562b16ffcbf0932ef1ec4cbfb6b1e18f/stripe-react-native.podspec#L5
| @@ -62,7 +62,7 @@ dependencies { | |||
| androidTestImplementation "androidx.test.ext:junit:$androidxJunitVersion" | |||
| androidTestImplementation "androidx.test.espresso:espresso-core:$androidxEspressoCoreVersion" | |||
|
|
|||
| implementation 'com.stripe:identity:20.28.2' | |||
| implementation 'com.stripe:identity:20.28.+' | |||
There was a problem hiding this comment.
Here is Identity's React Native Android version: https://github.com/stripe/stripe-react-native/blob/d565a0b1562b16ffcbf0932ef1ec4cbfb6b1e18f/android/build.gradle#L139
and its actual value: https://github.com/stripe/stripe-react-native/blob/d565a0b1562b16ffcbf0932ef1ec4cbfb6b1e18f/android/gradle.properties#L3
| @@ -19,7 +19,13 @@ change base application theme to `Theme.MaterialComponents.DayNight` at `res/val | |||
| ``` | |||
|
|
|||
| parent can be any MaterialComponents. [See here for other options](https://m2.material.io/develop/android/theming/dark/). | |||
| All process is here: https://github.com/capacitor-community/stripe/commit/f514d893e9193bed2edbaf52c0d3ed1d534c7890asU | |||
There was a problem hiding this comment.
This link seems inaccessible
|
@rdlabo Thanks for adding support for Identity! Made some changes to the readme and version, seems I don't have access add a reviewer here so cc you here FYI :) |
|
@ccen-stripe Thanks for the great job, I am glad that the Stripe team is interested in the Capacitor plugin. I will merge this in. |
Thanks for building the capacitor plugin for Stripe Identity! This PR fixed a small typo in README and added a section to add camera permission on iOS, also added details links to the native SDK.
For our react native wrapper, we pick up the latest Android/iOS minor version instead of using a fixed version, also made similar changes here.