-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Dashboard components to React components library #24
Conversation
1252917
to
8e6bd0f
Compare
4842e17
to
ffe0bd7
Compare
ffe0bd7
to
a9ff811
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified it locally and it works ok 👍 On my end, I noticed also the ,,race" and I needed to restart the app to work but it is not a big deal. :)
README.md
Outdated
This command watches for changes to Dashboard of any related packages to build | ||
them and live reload the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command watches for changes to Dashboard of any related packages to build | |
them and live reload the page. | |
This command watches for changes to Dashboard of any related packages to build them and live reload the page. |
Fortunately, you don't need to restart build - you can just e.g. add newline to any of the react component file, and it will trigger Dashboard rebuild with latest react components. So the race sometimes forces you to make double changes to see the initial change on Dashboard. |
Description
Changes proposed in this pull request:
Unfortunately I ran out of time to:
I will create a follow-up issue for that.
Relations
Needs #23 to be merged first
Testing
Follow the Readme to start app locally.
Also, see the sample repo with external usage of the components: https://github.com/pkosiec/dashboard-components-example
Issues
Among other things:
crypto
package included in components buildThe problem was:
Initially I checked facebook/create-react-app#11756 but it didn't seem right to have this error now, if previously we haven't had such issue.
Turned out that the
react-jsonschema-form
includesnanoid
as dependency, which needed another customization in Rollup config to use the browser environment: https://github.com/ai/nanoid#rollupThis is just a warning. It is a known issue: rjsf-team/react-jsonschema-form#2341 - cannot do anything about it
Related issue(s)
Resolves #21