Python 3 fixes #16
Merged
Python 3 fixes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @dronecfd |
|
Results from running
And on Python 2.7:
|
|
Thanks @capaulson :-). What are the prospects for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is against the Python3-Support branch.
from __future__ import print_functionso they still work for Python 2 as well.pyKriging.samplingplanI also profiled the sampling plan stage, and found a simple way to make it much faster - on my machine the
2D_model_convergence.pysample planning stage went from about 3 minutes to 10 seconds.The version of the code in this PR requires numpy 1.9 or above (for the
return_countsparameter in numpy.unique). 1.9 was released in September 2014, so most users should have a new enough version. If you want to support older versions of numpy, the last-but-one commit is almost as fast.