-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't generate binstubs by default when using Rails 4? #45
Comments
👍 |
1 similar comment
👍 |
Honestly, I won't change |
👍 |
1 similar comment
👍 |
👍 😄 |
👍 |
My solution for now... In
|
I'm using the same technique as @jweslley |
Same here :) |
👍 |
I also had to do what @jweslley recommended. Otherwise delayed job was not getting put in the bin directory. |
👍 |
1 similar comment
👍 |
👍 |
This would be nice to have. |
👍 |
1 similar comment
👍 |
...insert generic "worked for me too" comment here... |
So I haven't ever implemented this, since (AFAIK) no one with commit permissions has given the thumbs up. I have no idea whether there is a reasonable chance of a contribution being merged. |
@kirs has the final say :) |
@tisba: I would be interested in hearing the thinking behind why it works this way. |
@mustmodify not sure what you are referring to… This issue is about to change the default behavior of |
Sorry I wasn't clear. When I deploy, it seems that capistrano replaces my bin directory, leaving me without the files in my repo. You said, "Honestly, I won't change capistrano-bundlers default behavior here." So I assume there is some good reason why you think the current behavior is appropriate. It may be a great reason that I just don't understand. Would you care to enlighten me / us? |
I only changed the
But I have another project that uses |
1) bin/ is often checked out into repo 2) capistrano/bundler#45 (comment)
1) bin/ is often checked out into repo 2) capistrano/bundler#45 (comment)
1) bin/ is often checked out into repo 2) capistrano/bundler#45 (comment)
👍 |
I also recommend this. The "official recommendation" is to run |
@indirect thanks! |
|
Both PRs are merged. Thanks for discussion. Can be closed now. |
👍 |
👍 worked for me. |
The solution from @jweslley also worked for me. 👍 |
bundle --binstubs is any off you know what this do. |
I mean the full documentation. I could not find it |
@Frrank1 I think the only place in the official document where binstubs is explained is here: http://bundler.io/v1.11/man/bundle-exec.1.html |
Hey thanks @mattbrictson |
i think this configuration should be the default config/deploy.rb what do you guys think? |
@u007 it's the same solution as @jweslley and @mattbrictson suggested. |
(y) |
Thank you @jweslley. After 2+ hours fighting to get my app to deploy with webpack, removing 'bin' from linked_dirs finally worked for me. |
1) bin/ is often checked out into repo 2) capistrano/bundler#45 (comment)
1) bin/ is often checked out into repo 2) capistrano/bundler#45 (comment)
1) bin/ is often checked out into repo 2) capistrano/bundler#45 (comment)
When using Rails 4, the default options result in this error being raised when running a command from
bin
in a deployed environment:I have in fact checked in a
bin
with executables generated by Rails, but they are not used, because by defaultbin
is symlinked toshared/bin
, containing executables with bundler-generated executables. Of course it is trivial to configure bundler such that this doesn't happen, but since everyone using Rails 4 needs to do that, it would be better to just do 'the right thing' out of the box.Do you agree and are you interested in a pull request for this?
Edit:
Also see rails/rails#8974 and specifically rails/rails#8974 (comment)
The text was updated successfully, but these errors were encountered: