Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import bug fix #110

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Import bug fix #110

merged 2 commits into from
Jan 5, 2021

Conversation

fdosani
Copy link
Member

@fdosani fdosani commented Jan 5, 2021

Adding a small bug fix. Seems like we were missing importing an exception. Including a simple test too.

@fdosani fdosani added the bug Something isn't working label Jan 5, 2021
@fdosani fdosani requested a review from a team January 5, 2021 17:02
@fdosani fdosani removed the request for review from a team January 5, 2021 17:02
elzzhu
elzzhu approved these changes Jan 5, 2021
View reviewed changes
Copy link

@elzzhu elzzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdosani fdosani merged commit 8a6abcb into develop Jan 5, 2021
@fdosani fdosani deleted the import-bug-fix branch January 5, 2021 19:51
@fdosani fdosani mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elzzhu elzzhu elzzhu approved these changes

@jborchma jborchma Awaiting requested review from jborchma

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdosani @elzzhu