added pie animation #227
added pie animation #227
Conversation
There was a problem hiding this comment.
My apologies for the delay in reviewing.
Thanks for wanting to contribute. If you would like to continue, could you please sign the CLA as instructed above? Thanks.
I have reviewed it and I was unable to make it work without modifications changing references of this.props.animate to this.props.options.animate (as noted in review comments).
Also, it would probably be helpful to add an animated version of the pie chart in the example app (as a way of showing the option exists). Are you willing to add that?
src/Pie.js
Outdated
|
|
||
| } | ||
|
|
||
| _shouldAnim = () => this.props.animate.enabled && this.props.data.length > 1 |
There was a problem hiding this comment.
this.props.options.animate instead of this.props.animate
src/Pie.js
Outdated
| this._animationArray.map(a => | ||
| Animated.timing(a, { | ||
| toValue: 1, | ||
| duration: this.props.animate.duration |
There was a problem hiding this comment.
this.props.options.animate instead of this.props.animate
|
Also of important note, I've added a notice to the project readme that this project is going to be archived on February 28th. If you still want to get this change in before it gets archived we can do that if you can make the requested changes happen fairly soon. |
|
Hey, Thanks for the response. |
|
Thanks for signing the CLA and providing the example but I have one last minor request - could you add a link to the new example in the main menu of the example app? Thanks! |
|
Done. |
Thank you for contributing a pull request.
Please ensure that you have signed the CLA.