Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to set activeTabset to undefined #326

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexwaeseperlman
Copy link

This PR creates a way to not have a selected tab. I needed this feature for a project I'm working on with popout windows and I couldn't find another way to do it.

@alexwaeseperlman
Copy link
Author

Just checking in on the status of this PR

@david-trumid
Copy link

david-trumid commented Jul 13, 2023

Just checking in on the status of this PR

can you elaborate on the usage of not needing this? I am interested in something similiar cc @alexwaeseperlman

@alexwaeseperlman
Copy link
Author

For that project I ended up using my own fork

@alexwaeseperlman
Copy link
Author

Hi this has been open for a while. Is there a reason why it was never reviewed?

@nealus
Copy link
Collaborator

nealus commented Sep 17, 2023

Hi Alex, I think changing Actions.setActiveTabset to accept undefined would be better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants