Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add className from the model to Tab #342

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sorashi
Copy link

@sorashi sorashi commented Oct 23, 2022

The className property on the model in type: "tab" wasn't actually applied to the final Tab.

Example layout:

const layoutModel = FlexLayout.Model.fromJson({
    borders: [],
    layout: {
        type: "row",
        weight: 100,
        children: [
            {
                type: "tabset",
                weight: 50,
                children: [
                    {
                        type: "tab",
                        name: "Tab",
                        component: "tab-component",
                        className: "customclass",
                    }
                ]
            }
        ]
    }
})

Result is now:

<div class="flexlayout__tab customclass" data-layout-path="/ts1/t0" style="left: 118px; top: 32px; width: 546px; height: 890px; position: absolute;">

@sorashi
Copy link
Author

sorashi commented Oct 23, 2022

This is an updated version of #74 which is old and has conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant