fix clippy warning #1225
dwrenshaAnnotations
10 warnings
|
useless use of `vec!`:
capnp/src/serialize.rs#L1015
warning: useless use of `vec!`
--> capnp/src/serialize.rs:1015:24
|
1015 | let segments = vec![
| ________________________^
1016 | | vec![123, 0, 0, 0, 0, 0, 0, 0],
1017 | | vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0],
1018 | | ];
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
help: you can use an array directly
|
1015 ~ let segments = [vec![123, 0, 0, 0, 0, 0, 0, 0],
1016 ~ vec![4, 0, 0, 0, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0]];
|
|
|
useless use of `vec!`:
capnp/src/serialize.rs#L1047
warning: useless use of `vec!`
--> capnp/src/serialize.rs:1047:24
|
1047 | let segments = vec![
| ________________________^
1048 | | vec![1, 0, 0, 0, 0, 0, 0, 0],
1049 | | vec![2, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0],
1050 | | ];
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
|
1047 ~ let segments = [vec![1, 0, 0, 0, 0, 0, 0, 0],
1048 ~ vec![2, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0]];
|
|
|
type parameter `T` goes unused in function definition:
target/debug/build/fill_random_values-2fa3a13eb53b13ba/out/fill_capnp.rs#L2431
warning: type parameter `T` goes unused in function definition
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/fill_random_values-2fa3a13eb53b13ba/out/fill_capnp.rs:2431:28
|
2431 | pub fn get_field_types<T>(index: u16) -> ::capnp::introspect::Type where T: ::capnp::traits::Owned {
| ^
|
= help: consider removing the parameter
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
= note: `#[warn(clippy::extra_unused_type_parameters)]` on by default
|
|
type parameter `T` goes unused in function definition:
target/debug/build/fill_random_values-2fa3a13eb53b13ba/out/fill_capnp.rs#L2434
warning: type parameter `T` goes unused in function definition
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/fill_random_values-2fa3a13eb53b13ba/out/fill_capnp.rs:2434:33
|
2434 | pub fn get_annotation_types<T>(child_index: Option<u16>, index: u32) -> ::capnp::introspect::Type where T: ::capnp::traits::Owned {
| ^
|
= help: consider removing the parameter
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
this match could be replaced by its body itself:
target/debug/build/capnp-rpc-test-7aa99e2ff50a0c3a/out/test_capnp.rs#L6419
warning: this match could be replaced by its body itself
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/capnp-rpc-test-7aa99e2ff50a0c3a/out/test_capnp.rs:6419:7
|
6419 | / match method_id {
6420 | | _ => { ::capnp::capability::Promise::err(::capnp::Error::unimplemented("Method not implemented.".to_string())) }
6421 | | }
| |_______^ help: consider using the match body instead: `::capnp::capability::Promise::err(::capnp::Error::unimplemented("Method not implemented.".to_string()))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
= note: `#[warn(clippy::match_single_binding)]` on by default
|
|
type parameters go unused in function definition: Foo, Bar:
target/debug/build/capnpc-test-edition-2018-fcf521c3ca4657df/out/test_capnp.rs#L19583
warning: type parameters go unused in function definition: Foo, Bar
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/capnpc-test-edition-2018-fcf521c3ca4657df/out/test_capnp.rs:19583:33
|
19583 | pub fn get_annotation_types<Foo,Bar>(child_index: Option<u16>, index: u32) -> ::capnp::introspect::Type where Foo: ::capnp::traits::O...
| ^^^ ^^^
|
= help: consider removing the parameters
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
= note: `#[warn(clippy::extra_unused_type_parameters)]` on by default
|
|
type parameters go unused in function definition: Foo, Bar:
target/debug/build/capnpc-test-edition-2018-fcf521c3ca4657df/out/test_capnp.rs#L19854
warning: type parameters go unused in function definition: Foo, Bar
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/capnpc-test-edition-2018-fcf521c3ca4657df/out/test_capnp.rs:19854:35
|
19854 | pub fn get_annotation_types<Foo,Bar>(child_index: Option<u16>, index: u32) -> ::capnp::introspect::Type where Foo: ::capnp::traits:...
| ^^^ ^^^
|
= help: consider removing the parameters
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameters go unused in function definition: Foo, Bar, Baz:
target/debug/build/capnpc-test-edition-2018-fcf521c3ca4657df/out/test_capnp.rs#L20226
warning: type parameters go unused in function definition: Foo, Bar, Baz
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/capnpc-test-edition-2018-fcf521c3ca4657df/out/test_capnp.rs:20226:35
|
20226 | pub fn get_annotation_types<Foo,Bar,Baz>(child_index: Option<u16>, index: u32) -> ::capnp::introspect::Type where Foo: ::capnp::tra...
| ^^^ ^^^ ^^^
|
= help: consider removing the parameters
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
type parameters go unused in function definition: Foo, Bar, Baz, Qux:
target/debug/build/capnpc-test-edition-2018-fcf521c3ca4657df/out/test_capnp.rs#L20595
warning: type parameters go unused in function definition: Foo, Bar, Baz, Qux
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/capnpc-test-edition-2018-fcf521c3ca4657df/out/test_capnp.rs:20595:37
|
20595 | ... pub fn get_annotation_types<Foo,Bar,Baz,Qux>(child_index: Option<u16>, index: u32) -> ::capnp::introspect::Type where Foo: ::capnp:...
| ^^^ ^^^ ^^^ ^^^
|
= help: consider removing the parameters
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
|
very complex type used. Consider factoring parts into `type` definitions:
target/debug/build/capnpc-test-edition-2018-fcf521c3ca4657df/out/test_capnp.rs#L20674
warning: very complex type used. Consider factoring parts into `type` definitions
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/capnpc-test-edition-2018-fcf521c3ca4657df/out/test_capnp.rs:20674:43
|
20674 | ...-> ::capnp::capability::Request<crate::test_capnp::test_generics::inner2::Owned<Foo,Bar,::capnp::text_list::Owned>,crate::test_capnp::test_generics::inner2::Owned<Foo,Bar,::capnp::primitive_list::Owned<i16>>...
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|