ArrayPtr-based async read api. #2084
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikea
force-pushed
the
maizatskyi/2024-06-07-async-read-api
branch
3 times, most recently
from
c5dab09
to
7cae47a
Compare
mikea
added a commit
to cloudflare/workerd
that referenced
this pull request
Jun 21, 2024
Downstream of capnproto/capnproto#2084
mikea
force-pushed
the
maizatskyi/2024-06-07-async-read-api
branch
2 times, most recently
from
f5325ec
to
4f73201
Compare
mikea
added a commit
to cloudflare/workerd
that referenced
this pull request
Jun 24, 2024
Downstream of capnproto/capnproto#2084
kentonv
reviewed
Jun 24, 2024
| @@ -1514,7 +1514,7 @@ public: | |||
| co_return true; | |||
| } | |||
|
|
|||
| auto amount = co_await inner.tryRead(headerBuffer.begin(), 1, headerBuffer.size()); | |||
| auto amount = co_await inner.tryRead(headerBuffer.asBytes(), 1); | |||
Not really. I don't think I have changed anything in "real" code. Tests had some cleanup that was mostly related to string/bytes simplifications where possible. Otherwise I tried to stay as close as possible to the original. |
|
I also have downstream changes ready and I obviously plan to make sure all builds pass everywhere before starting to merge. |
jasnell
approved these changes
Jun 24, 2024
kentonv
approved these changes
Jun 24, 2024
mikea
force-pushed
the
maizatskyi/2024-06-07-async-read-api
branch
from
4f73201
to
d04996c
Compare
mikea
added a commit
to cloudflare/workerd
that referenced
this pull request
Jul 24, 2024
Downstream of capnproto/capnproto#2084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.