Fix #394

This fixes the data race by moving the return before fulfill(); this way Return() is not modifying the message while other callers are accessing it.
capnproto · Jan 9, 2023 · 7844043 · 7844043
1 parent 3c3ee7e
commit 7844043
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/server/server.go b/server/server.go
@@ -216,12 +216,12 @@ func (srv *Server) handleCall(ctx context.Context, c *Call) {
 	err := c.method.Impl(ctx, c)
 
 	c.recv.ReleaseArgs()
+	c.recv.Returner.Return(err)
 	if err == nil {
 		c.aq.fulfill(c.results)
 	} else {
 		c.aq.reject(err)
 	}
-	c.recv.Returner.Return(err)
 	c.recv.Returner.ReleaseResults()
 }