Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect locking in question.PipelineSend #382

Closed
zenhack opened this issue Dec 13, 2022 · 1 comment
Closed

Incorrect locking in question.PipelineSend #382

zenhack opened this issue Dec 13, 2022 · 1 comment
Labels

Comments

@zenhack
Copy link
Contributor

zenhack commented Dec 13, 2022

Conn.sendMessage()'s comment states that the caller must be holding the lock, but question.PipelineSend invokes it in an explicit call to syncutil.Without. Unfortunately, just removing it deadlocks, since the nested call to newPipelineCallMessage tries to acquire the lock. This needs to be reworked so we're following all contracts.

@zenhack zenhack added the bug label Dec 13, 2022
@zenhack
Copy link
Contributor Author

zenhack commented Dec 14, 2022

The same thing is happening in importClient.Send w/ newImportCallMessage

lthibault added a commit that referenced this issue Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant