Error client: return the error via Brand() #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've found this useful in some debugging I'm doing on a separate branch. It will also make it easier to detect error clients elsewhere in the code.
We didn't used to do this, but started doing so for expidiency when isLocalClient was introduced. It's not really a big deal, but now that ErrorClients return the error via Brand(), we can detect this fairly easily and skip the embargo.
lthibault
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two related small improvements:
errorClientnow lets you get at the underlyingerrorvia.Brand()isLocalClientuses this fact to skip the unnecessary embargo for error clients.As mentioned in the second commit message, the latter is changing the behavior back to what it was before
isLocalClientwas introduced; it was changed in the first place mostly for expediency and this isn't a huge deal, but it is a bit better.