Assorted clean-up tasks #265

lthibault · 2022-07-13T13:16:38Z

This PR bundles a few different clean-up chores and minor updates.

remove unused needsEscape and hexDigit functions from package encoding/text.
fix (hitherto unencountered) nil-pointer dereference in TestBuildNodeMap.
declare Helper tests in packed to reduce visual noise in test results and stack traces.
run message encode/decode tests in parallel (in an attempt to reduce CI timeouts)

go.mod

This reverts commit 6412c15.

lthibault added 5 commits July 13, 2022 14:13

Remove needsEscape and hexDigit from package encoding/text.

ec4ddff

Replace calls to deprecated strings.Title with cases.Caser.

6412c15

Fix (unencountered) nil-pointer dereference in TestBuildNodeMap

86a9b83

Declare golang.org/x/test as direct dependency.

3bc77d1

Label helper tests in package packed.

e9610f5

lthibault added the cleanup label Jul 13, 2022

lthibault requested a review from zenhack July 13, 2022 13:16

Run message tests in parallel.

12bd977

zenhack reviewed Jul 15, 2022

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Revert "Replace calls to deprecated strings.Title with cases.Caser."

e22199f

This reverts commit 6412c15.

lthibault requested review from zenhack July 15, 2022 18:41

zenhack approved these changes Jul 15, 2022

View reviewed changes

zenhack merged commit ed853e6 into main Jul 15, 2022

lthibault deleted the cleanup/dead-code branch July 15, 2022 19:40

Provide feedback