First steps towards generics #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenhack
commented
Jul 30, 2022
|
Just tacked on one more commit, which makes Ptr implement TypeParam as well. But probably should not have a giant generics pr, so once you're happy we should merge. |
lthibault
reviewed
Jul 30, 2022
...and implement it for basic pointer types, and generated types where appropriate. This is the first step on generics support.
|
Rebased on top of main, dropped a bit of generated code rendered unnecessary by the embedding. |
lthibault
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
TypeParaminterface capturing operations we will need in order to support generics, and makes sure that the expected types implement it.Not super useful on its own, but in the interest of keeping PRs small and easy to review...