Clean up import rendering in codegen. #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, this still has the commits from #285 on it, even though that's merged... makes the diff hard to follow... |
|
Rats. I'll rebase and push. |
lthibault
force-pushed
the
cleanup/refactor-codegen-imports
branch
from
6334ac6 to
ea55d5c
Compare
|
Fixed. |
|
Bump. Is this okay to merge? |
zenhack
reviewed
Aug 21, 2022
zenhack
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactor that aims for an incremental improvement to
fileparts.go's readability.I had to stare at the
importsstruct a wee bit longer than I would have liked, owing to the indirection in its initialization. This PR removes theimports.initmethod and replaces it with a simplenewImportsconstructor. Runtime behavior is unaffected.