Delete clearCapTable() #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation added in capnproto#308 makes this redundant; the ReleaseFuncs returned by the transport already releases any caps in the message, and in all cases this was called immediately before releasing the message as a whole. Not doing this at every call site will make things less brittle. Note that there is no functional change here, in particular this is not fixing a double free bug: since clearCapTable sets CapTable to nil, it doesn't clash with the call to msg.Reset in the ReleaseFunc.
lthibault
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation added in #308 makes this redundant; the ReleaseFuncs returned by the transport already releases any caps in the message, and in all cases this was called immediately before releasing the message as a whole. Not doing this at every call site will make things less brittle.
Note that there is no functional change here, in particular this is not fixing a double free bug: since clearCapTable sets CapTable to nil, it doesn't clash with the call to msg.Reset in the ReleaseFunc.