Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release() method to capnp.Arena. #432

Merged
merged 3 commits into from
Jan 15, 2023
Merged

Conversation

lthibault
Copy link
Collaborator

Exports the Release() method from the public Arena interface, to support pooling of arenas. Adds Release() method to SingleSegmentArena, and other private arena types.

Copy link
Contributor

@zenhack zenhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor gripe about the docs, but otherwise this looks ok.

message.go Outdated Show resolved Hide resolved
@lthibault
Copy link
Collaborator Author

--- FAIL: TestSendDisembargo (0.01s)
    --- FAIL: TestSendDisembargo/SendQueuedResultToCaller (0.01s)
Error:         level1_test.go:285: Received finish message; want disembargo
Error:         level0_test.go:2126: conn error: rpc: send release: send message: context canceled`

This again. Merging.

@lthibault lthibault merged commit 54d41bf into main Jan 15, 2023
@zenhack zenhack deleted the feature/single-segment-pool branch January 15, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants