Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of
rpc.Conn
for readability. There are no functional changes.Clean-up is concentrated in two places:
switch
statement inConn.receive
is tidied up by having eachcase
call out to a dedicated "handler" method.Thereader
thread is moved into its own task, allowing it to trigger task shutdown on its own. This in turn lets us implementreceiver
as a simplerange
loop over a channel.A follow-up effort will focus on abstracting tasks & connection lifecycle.