Remove more uses of fmt. #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I think I see a way of doing this without dropping some of these; going to do another pass. |
zenhack
force-pushed
the
more-fmt-reduction
branch
from
cd4d2c5 to
51a76e4
Compare
We don't really need this, and it pulls in fmt.
We know the type at generation time, so there's no need for this.
|
Ok, did another pass which should fix the tests; we now only get rid of the one String() method on StructList. Most others are left in place and instead we remove uses of fmt from encoding/text. In addition to errgroup, the schemas package still transitively pulls in fmt via compress/zlib. #89 is related; we'd like to make embedding the schema at all optional. |
|
Note also, this PR drops the size of tempest's WASM blob from 624K to 460K, so that's cool. |
lthibault
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
After this patch, tempest's UI only pulls in fmt as a dependency of errgroup. I may look to see if we can avoid errgroup or build a lightweight alternative...