Decompose answer struct. #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...based on whether or not we need to access the field through c.lk.
We never actually invoke it directly from ansReturner.
The comments for msgReleaser suggest we can't hold the lock while doing this, so add it to the releaseList instead. I'd like to make this harder to mess up in the future.
This is obsolete, now that we have to go through c.lk to get to the entry. This patch also drops all of the parameters that were transitively passed to assertIs(). We do still sometimes want to actually *use* the connection though, so we add a method to ansent to fetch it, which localizes the cast.
lthibault
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the
answerstruct in the rpc package intoansentandansReturner, which makes it more similar to e.g.impent/importClient. This should make this generally easier to understand and work with.Along the way I spotted a place where we were violating a documented invariant, and fixed it (9161f0e). Otherwise there is no functional change.