Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exc.WrapError: return nil if the original error is nil. #506

Merged
merged 1 commit into from
Apr 19, 2023
Merged

exc.WrapError: return nil if the original error is nil. #506

merged 1 commit into from
Apr 19, 2023

Conversation

zenhack
Copy link
Contributor

@zenhack zenhack commented Apr 19, 2023

I'm finding this convenient in Tempest

@zenhack zenhack requested a review from lthibault April 19, 2023 23:24
@zenhack
exc.WrapError: return nil if the original error is nil.
d7f3a1c 
I'm finding this convenient in Tempest
lthibault
lthibault approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@lthibault lthibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear, I set out to make this change at least 5 times, and somehow never managed to open the friggin' PR.

Approved, obviously :)

@lthibault lthibault merged commit eef5a9b into capnproto:main Apr 19, 2023
@zenhack zenhack deleted the WrapError-nil branch April 19, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lthibault lthibault lthibault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenhack @lthibault