Don't use $GOPATH in instructions. #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per some prior discussions, GOPATH is basically dead at this point, and using it here obscures what's really going on: you just need the code checked out somewhere so you can pass -I /path/to/go-capnp/std to capnp compile
lthibault
approved these changes
May 8, 2023
zenhack
added a commit
to zenhack/go-capnp
that referenced
this pull request
May 8, 2023
I realized with capnproto#512 I'd missed the installation instructions here -- but rather than just updating them, I've removed the bits that are covered elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per some prior discussions, GOPATH is basically dead at this point, and using it here obscures what's really going on: you just need the code checked out somewhere so you can pass -I /path/to/go-capnp/std to capnp compile