Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint configuration is broken in Sanity #147

Open
an2n opened this issue Jan 16, 2025 · 4 comments
Open

ESLint configuration is broken in Sanity #147

an2n opened this issue Jan 16, 2025 · 4 comments
Labels
Bug Sanity Tasks related to Sanity

Comments

@an2n
Copy link
Collaborator

an2n commented Jan 16, 2025

The SvelteKit template sanity-template-sveltekit-clean has an ESLint configuration that does not work. I have made an attempt to upgrade to ESLint 9 with FlatConfig following this issue, but no success. There are several linting errors that need to be investigated after updating it.
@an2n an2n added Sanity Tasks related to Sanity Bug labels Jan 16, 2025
@an2n an2n mentioned this issue Jan 16, 2025
Merged
@TheKnarf
Copy link
Collaborator

Let's replace ESLint with Biome? And put it in the root of the repo for the whole repo

an2n added a commit that referenced this issue Jan 16, 2025
@an2n
Docs/readme (#146)
bee5a3d 
Added task for issue #147

---------

Co-authored-by: Anton Lilleby <antonlilleby@Anton-sin-MacBook-Pro.local>
@an2n
Copy link
Collaborator Author

an2n commented Jan 16, 2025

Biome is not supported for SvelteKit afaik: https://biomejs.dev/internals/language-support.

@TheKnarf
Copy link
Collaborator

Biome is not supported for SvelteKit afaik: https://biomejs.dev/internals/language-support.

⚠️: Partially supported (with some caveats)

@an2n
Copy link
Collaborator Author

an2n commented Jan 17, 2025

I'm not sure if that includes SvelteKit, and I don't feel confident relying on partial support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Sanity Tasks related to Sanity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheKnarf @an2n