Migrate from jenkins to GitHub actions #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakimen
commented
Feb 7, 2024
| // We only run semantic-release on the release branches, | ||
| // as we do not want credentials to be exposed to the job | ||
| // on other branches or in PRs. | ||
| if (env.BRANCH_NAME ==~ /^(master|\d+\.(\d+|x)(\.x)?)$/) { |
There was a problem hiding this comment.
Didn't include support for releasing from non-trunk branches, such as referenced here.
We don't have any such branches today, nor any plans on supporting it afaik
|
Before adding these changes, we need to decide how to handle public NPM packages, marking as draft for now. |
npm token strategy has been decided, and token has been added to workflow according to the semrel guide |
stekern
suggested changes
Feb 9, 2024
stekern
approved these changes
Feb 9, 2024
joakimen
force-pushed
the
jol/CALS-705/migrate-from-jenkins-to-github-actions
branch
from
c909931
to
c1fb632
Compare
joakimen
deleted the
jol/CALS-705/migrate-from-jenkins-to-github-actions
branch
|
🎉 This PR is included in version 2.19.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.