#1144@patch: Run tests against newer Node.js versions #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed tests that were failing locally for me (running on Node.js 18), for various reasons.
IGx89
commented
Oct 26, 2023
packages/uncaught-exception-observer/test/UncaughtExceptionObserver.test.ts
Show resolved
Hide resolved
capricorn86
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Thank you for your contribution @IGx89! 🌟
I looked into dateIsoWeek() and It seems like we are using this:
https://stackoverflow.com/a/16591175/12415847
But we should probably use this (it seems like JSDOM is using this one as well):
https://stackoverflow.com/a/6117889/12415847
I have changed it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed tests that were failing locally for me, for various reasons.
Closes #1144