-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universal wheel for macOS contains only x86_64 build #2154
Comments
Do you want to use Capstone for |
I want it to not crash. Not even disassembling. |
Added in #2081 |
Compile from Apple Silicon: $ make -j8
[ 1%] Building C object CMakeFiles/capstone.dir/Mapping.c.o
[ 1%] Building C object CMakeFiles/capstone.dir/MCInst.c.o
[ 1%] Building C object CMakeFiles/capstone.dir/cs.c.o
[ 3%] Building C object CMakeFiles/capstone.dir/MCInstPrinter.c.o
[ 3%] Building C object CMakeFiles/capstone.dir/SStream.c.o
[ 5%] Building C object CMakeFiles/capstone.dir/utils.c.o
[ 5%] Building C object CMakeFiles/capstone.dir/MCInstrDesc.c.o
[ 5%] Building C object CMakeFiles/capstone.dir/MCRegisterInfo.c.o
/Users/kabeor/capstone/MCInstPrinter.c:91:1: error: non-void function does not return a value in all control paths [-Werror,-Wreturn-type]
}
^
/Users/kabeor/capstone/MCInst.c:284:1: error: non-void function does not return a value in all control paths [-Werror,-Wreturn-type]
}
^
1 error generated.
1 error generated.
[ 5%] Building C object CMakeFiles/capstone.dir/arch/ARM/ARMBaseInfo.c.o
make[2]: *** [CMakeFiles/capstone.dir/MCInst.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [CMakeFiles/capstone.dir/MCInstPrinter.c.o] Error 1
[ 6%] Building C object CMakeFiles/capstone.dir/arch/ARM/ARMDisassembler.c.o
make[1]: *** [CMakeFiles/capstone.dir/all] Error 2
make: *** [all] Error 2 About MCInstPrinter.c, I guess Since the code comes from #1949, Would you mind to have a look? @Rot127 |
Should be fixed in #2160. However, the homebrew way is not maintaining by us, compiling source code is ok. |
@kabeor I'll wait for the published |
I'm also encountering the same problem. Is there a release schedule coming soon so I can install the package directly from |
A possible workaround could be to force it to build the x86_64 dylib, then link them together using lipo. But I can't seem to get the x86_64 dylib built. Even if I run
The resulting dylib is arm64. Same result for the cython build. |
Should be fixed via a554a1d |
It seems like this is still not fixed |
@acama it should be a part of the upcoming 5.0.2 release |
The issue persists and should be reopened |
When installing the package on an Apple Silicon, the universal wheel being installed is only for intel.
This can be examined:
file /opt/homebrew/lib/python3.11/site-packages/capstone/lib/libcapstone.dylib # outputs: /opt/homebrew/lib/python3.11/site-packages/capstone/lib/libcapstone.dylib: Mach-O 64-bit dynamically linked shared library x86_64
As a result,
capstone
will fail to import on Apple Silicon.The text was updated successfully, but these errors were encountered: