Apple compatibility changes for #2026 + misc. AARCH64 naming cleanups. #1
Conversation
leaves `CAPSTONE_HAS_ARM64` supported
`testFeatureBits` should check if the platform function is visible first
Apple compiler really hates typecasting a enum, even if bounded from a unsigned. Lets set the raw_value directly is a hack and needs proper review
There was a problem hiding this comment.
Thanks a lot for all those little improvements!
Please note that the Makefile build method is essentially deprecated. So if you script something, better use cmake.
Also thank you for updating the test files. If you are not aware of it, please take a look at capstone-engine#1984 though. Just consider this issue, if you want to add more tests.
| if (Reg) | ||
| sysop.reg = Reg->SysReg; | ||
| else { | ||
| sysop.reg.sysreg = (aarch64_sysreg)Val; |
There was a problem hiding this comment.
| sysop.reg.sysreg = (aarch64_sysreg)Val; |
Since raw_val gets set...
| @@ -638,7 +638,7 @@ typedef enum { | |||
| typedef enum { | |||
| // generated content <AArch64GenCSSystemOperandsEnum.inc:GET_ENUM_VALUES_SysReg> begin | |||
| // clang-format off | |||
|
|
|||
| AArch64_SYSREG_BEGIN = 0x0, | |||
There was a problem hiding this comment.
Its not formatted probably. But as a side note: you can ignore formatting for now. If it is not too bad. After the PR is merged I'll do a single clang-format PR.
Just be aware that Capstone uses tabs.
There was a problem hiding this comment.
ah! I was wondering why the formatting was being so clunky! thanks! I should have some time tonight to look through all these
Rot127
force-pushed
the
auto-sync-aarch64
branch
4 times, most recently
from
6eb0ced
to
2db40f6
Compare
|
Its in |
note: changes to
MakefileleavesCAPSTONE_HAS_ARM64supported.